add proportions_ztest to test examples #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Zabelin <[email protected]>
Signed-off-by: Paul Zabelin <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR, titled "Cat math", updates several test cases related to success rate calculations and sample size estimations, while also adding a new contributor to the project.
- Updated test parameters and messages in team_recommender tests to refine the numerical boundaries.
- Added a new test suite for sample size functions and introduced an alternative implementation using a loop.
- Updated CONTRIBUTORS.md to include a new contributor.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| examples/team_recommender/tests/test_helpers.py | Updated test cases and added new tests for success rate and sample size calculations. |
| CONTRIBUTORS.md | Added a new contributor entry. |
Comments suppressed due to low confidence (1)
examples/team_recommender/tests/test_helpers.py:118
- The test tuple uses a success rate value of 0.9997 (99.97%) while the accompanying message states 99.99%; please update one of these to ensure clarity and consistency.
(1, 50000, 0.9997, "99.99% success rate is below expected 97% success rate"),
Signed-off-by: Paul Zabelin <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request, titled "Cat math", introduces additional tests for statistical functions related to proportions z-test calculations and augments helper functions for sample size estimation.
- Adds comprehensive tests to validate proportions z-test outcomes under various scenarios.
- Introduces helper functions for determining the next sample size along with corresponding tests.
- Updates dependency configuration (pyproject.toml) and contributors list.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| examples/team_recommender/tests/test_proportions_ztest.py | Adds new tests for proportions z-test functionality with various statistical scenarios. |
| examples/team_recommender/tests/test_helpers.py | Introduces helper functions and tests related to sample size calculations. |
| CONTRIBUTORS.md | Updates contributors list by adding a new contributor. |
| pyproject.toml | Adds a new dependency required for statistical computations. |
Signed-off-by: Paul Zabelin <[email protected]>
Signed-off-by: Paul Zabelin <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Paul Zabelin <[email protected]>
Contributor
|
🐻 approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proportions_ztest
and compare it with current StatisticalAnalysis
Testing framework updates:
examples/team_recommender/tests/test_helpers.py: Added new test cases and modified existing ones to improve the accuracy of success rate measurements and sample size calculations. [1] [2] [3] [4]examples/team_recommender/tests/test_proportions_ztest.py: Added new tests for theproportions_ztestfunction to check for statistical significance and improvements in success rates.Contributors update:
CONTRIBUTORS.md: Added Carl Jackson to the list of contributors.Dependency update:
pyproject.toml: Addedstatsmodelsto the list of test dependencies.